Messages in this thread | | | Date | Sat, 1 Mar 2008 14:40:01 +0100 | From | Pierre Ossman <> | Subject | Re: [RFC][PATCH] cpuidle: avoid singing capacitors |
| |
On Fri, 29 Feb 2008 19:38:12 +0100 Pierre Ossman <drzeus-list@drzeus.cx> wrote:
> @@ -50,9 +58,16 @@ static int menu_select(struct cpuidle_device *dev) > break; > if (s->exit_latency > pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY)) > break; > + if ((dev->states[i].flags & CPUIDLE_FLAG_DEEP) && > + time_before_eq(jiffies, data->last_deep_jif + MIN_DEEP_INTERVAL)) > + break; > } >
I guess another approach would be to refuse to enter deep sleep if the sleep time is less than 2 ms. That would mean we would not lose the long sleeps, but if it is just doing short sleeps then we would never enter C3...
Is there a decent way of testing which approach is actually doing the least damage?
Rgds
-- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
| |