lkml.org 
[lkml]   [2008]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] cpuidle: avoid singing capacitors
On Fri, 29 Feb 2008 19:38:12 +0100
Pierre Ossman <drzeus-list@drzeus.cx> wrote:

> @@ -50,9 +58,16 @@ static int menu_select(struct cpuidle_device *dev)
> break;
> if (s->exit_latency > pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY))
> break;
> + if ((dev->states[i].flags & CPUIDLE_FLAG_DEEP) &&
> + time_before_eq(jiffies, data->last_deep_jif + MIN_DEEP_INTERVAL))
> + break;
> }
>

I guess another approach would be to refuse to enter deep sleep if the sleep time is less than 2 ms. That would mean we would not lose the long sleeps, but if it is just doing short sleeps then we would never enter C3...

Is there a decent way of testing which approach is actually doing the least damage?

Rgds

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org


\
 
 \ /
  Last update: 2008-03-01 14:43    [W:0.108 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site