lkml.org 
[lkml]   [2008]   [Mar]   [1]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 1 Mar 2008 20:45:15 +0200
FromAdrian Bunk <>
SubjectRe: [2.6 patch] acpi/battery.c: make 2 functions static
On Sat, Mar 01, 2008 at 09:42:59PM +0300, Alexey Starikovskiy wrote:
> Adrian Bunk wrote:
>> On Sat, Mar 01, 2008 at 09:26:41PM +0300, Alexey Starikovskiy wrote:
>> 
>>> May I keep them inline?
>>> 
>>
>> The problem with such manual inlines is that we force gcc to always  
>> inline them - and history has shown that functions grow without the  
>> "inline" being removed.
>>
>>   And for static functions gcc should (at least in theory) know best 
>> when to inline them.
>>
>> 
> Right. Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>
> As I understand, you have some automation tools for finding out these
> non-static functions, etc; are they available somewhere?

Type "make namespacecheck" after compiling the kernel.  

> Regards,
> Alex.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-03-01 19:49    [from the cache]
©2003-2008