Messages in this thread |  | | | Subject | Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7) | | From | James Bottomley <> | | Date | Fri, 08 Feb 2008 23:23:48 -0600 | |
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + ibft_device = kmalloc(len, GFP_KERNEL);
> + if (!ibft_device)
> + return -ENOMEM;
> +
> + memcpy(ibft_device, hdr, len);
This piece looks a bit odd. you're making ibft_device an exact
duplicate of ibft_addr (which is reserved in bootmem and lives as long
as the kernel does). I can't seem to find anywhere you actually modify
ibft_device, so why not just use the original ibft_addr here instead of
making a copy?
James
|  |