lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture
    From
    Date

    On Fri, 2008-02-08 at 09:45 +0000, Russell King - ARM Linux wrote:
    > If we are serious about allowing ARM to use drivers/Kconfig, then let's
    > not get distracted by perfection - by trying to do too many changes in
    > one go.
    >
    > If, today, we conditionalise MTD or IDE on a certain set of symbols,
    > then those conditions should be preserved in the first step - it should
    > be a 1:1 translation.

    That makes some sense. Currently you have:

    if ALIGNMENT_TRAP || !CPU_CP15_MMU
    source "drivers/mtd/Kconfig"
    endif

    > Later, if there's a need to improve it (as you're suggesting) that should
    > be a *separate* change.

    We can certainly improve the behaviour later, it's true -- it's not the
    end of the world if we continue to have the whole of the MTD layer
    turned off on platforms with alignment problems for now.

    But still, it's HAVE_UNALIGNED_ACCESS which we want to depend on, not a
    newly-invented HAVE_MTD. And there are other places we really ought to
    be depending on HAVE_UNALIGNED_ACCESS too.

    --
    dwmw2



    \
     
     \ /
      Last update: 2008-02-08 11:21    [W:0.023 / U:30.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site