lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [-mm PATCH] sysdev_unregister() should call kobject_del()
From
Date

On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote:
> On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote:
> > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote:
> > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote:
> > > > Hi Greg,
> > > >
> > > > While playing with hotplug memory remove on 2.6.24-mm1, I
> > > > noticed that /sysfs directory entries are not getting removed.
> > > >
> > > > sysdev_unregister() used to call kobject_unregister().
> > > > But in 2.6.24-mm1, its only dropping the ref. It should
> > > > call kobject_del() to remove the object. Correct ?
> > > >
> > > > With this change, the directories are getting removed
> > > > correctly. Comments ?
> > >
> > > Ick, no, this shouldn't be needed, someone else must be holding a
> > > reference to the kobject device somewhere. See the kobject documenation
> > > for more info.
> > >
> > > I'll try to see where we grab 2 references...
> >
> > I will take a closer look then. I was taking easy way out :(
>
> Hm, I don't see anything obvious in the sys.c core. What code is
> controlling these objects that you are creating and removing from the
> system?

add_memory_block()/register_memory() is creating sysfs entries
for the memory blocks.

I am trying to make use of remove_memory_block() to clean up
sysfs entries. BTW, remove_memory_block() is never tested
before, since we don't support memory remove yet.

Thanks,
Badari



\
 
 \ /
  Last update: 2008-02-08 06:11    [W:0.065 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site