lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Add iSCSI iBFT support (v0.4.6)
    Date
    On Friday 01 February 2008 19:18:09 James Bottomley wrote:
    > On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
    > > This patch (v0.4.6) adds

    > Some pieces of the patch are obviously wrong: find_ibft() shouldn't be
    > in ibft_init ... if ibft_phys was zero, it means the bootmem reservation
    > wasn't done and you shouldn't be poking about in memory which has likely
    > now been overwritten.
    Fixed.
    >
    > Also, why is ibft_phys the global variable you pass? You never actually
    > want to use the physical address, what you always end up using is the
    > kernel virtual address.
    >
    > I'd simply use the ibft variable to point to the virtual address of the
    > ibft or null if not found, then you can throw out all the phys_to_virt()
    > calls.
    Fixed.
    >
    > Also, move the reserve_bootmem into the ibft_find routines and ensure
    > they're only called once on boot. Refuse to attach the ibft driver if
    > the virtual pointer ibft is null.

    James,

    Thanks for your review. If you wouldn't mind, can you take a look
    at the version 0.4.7 (http://lkml.org/lkml/2008/2/8/350) which has your
    suggestions incorporated.

    Thanks again.


    \
     
     \ /
      Last update: 2008-02-08 21:43    [W:0.023 / U:31.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site