lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: blackfin compile error
    On Feb 8, 2008 1:25 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
    >
    > On Feb 6, 2008 2:12 PM, Robin Getz <rgetz@blackfin.uclinux.org> wrote:
    > > On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
    > > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
    > > > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
    > > > >
    > > > > <-- snip -->
    > > > >
    > > > > ...
    > > > > CC mm/vmscan.o
    > > > > In file included from
    > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
    > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
    > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
    > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
    > > > > make[2]: *** [mm/vmscan.o] Error 1
    > > >
    > > > This suggests that no one's tried to compile -mm on Blackfin since
    > > > before September, I think.
    > >
    > > Or any other nommu arch's either, since looking at the include files, FRV
    > > (when configured as noMMU) and m68knommu does not include it either...
    > >
    > > > Is there somewhere more appropriate to move it? I can't find one.
    > > > Failing that, we can wrap it in CONFIG_MMU, I suppose.
    > >
    > > Or just add to the the following:
    > >
    > > ./include/asm-blackfin
    > > ./include/asm-frv/ (only when configured as !MMU)
    > > ./include/asm-h8300
    > > ./include/asm-m68knommu
    > > ./include/asm-v850
    > >
    > > Others seem to have it in include/asm-xxxxx/pgtable.h as #define, inline
    > > function, or extern.
    >
    > looks like only MMU code currently uses the function, but to keep
    > things nice, we may want something like:
    > static inline int is_swap_pte(pte_t pte)
    > {
    > #ifdef CONFIG_MMU
    > return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
    > #else
    > return 0;
    > #endif
    > }
    >
    > the header is also lacking an #include <asm/pgtable.h> at the top ...
    > -mike
    >

    Did you submit a patch to mainline? It should be merged to fix this
    compiling error.

    Thanks a lot
    -Bryan


    \
     
     \ /
      Last update: 2008-02-08 19:57    [W:0.038 / U:89.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site