Messages in this thread |  | | | Date | Fri, 8 Feb 2008 19:45:01 +0100 | | From | Andi Kleen <> | | Subject | Re: [PATCH] x86: Simplify cpu_idle_wait | |
On Fri, Feb 08, 2008 at 09:24:30AM -0800, Venki Pallipadi wrote:
> On Fri, Feb 08, 2008 at 11:28:48AM +0100, Andi Kleen wrote:
> >
> > > - set_cpus_allowed(current, tmp);
> > > + smp_mb();
> > > + /* kick all the CPUs so that they exit out of pm_idle */
> > > + smp_call_function(do_nothing, NULL, 0, 0);
> >
> > I think the last argument (wait) needs to be 1 to make sure it is
> > synchronous (for 32/64) Otherwise the patch looks great.
>
> Yes. Below is the updated patch
Acked-by: Andi Kleen <ak@suse.de>
-Andi
|  |