Messages in this thread | | | Date | Fri, 8 Feb 2008 11:27:09 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/6] Core driver for WM97xx touchscreens |
| |
On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote:
> The probe error handling is not quite correct. When we reach the fragment > above ret variable is 0 so if platfrom_device_alloc() fails we will return > 0 and the device will be considered bound but in half-dead state. Please > make sure that proper error is returned in all cases. Also please do not > mix out of line and in-line error unwinding (input_free_device() should > be called in the error path and if you are concerned about double-free > after input_unregister_device() just set wm->input_dev to NULL there).
Thanks for the review, I've implemented these changes and will resubmit as a followup to this e-mail, also including a change from Dmitry Baryshkov to make the devices unnumbered.
| |