lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 04/45] USB: keyspan: Fix oops

    2.6.24-stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Alan Cox <alan@lxorguk.ukuu.org.uk>

    If we get a data URB back from the hardware after we have put the tty to
    bed we go kaboom. Fortunately all we need to do is process the URB
    without trying to ram its contents down the throat of an ex-tty.

    Signed-off-by: Alan Cox <alan@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/serial/keyspan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/keyspan.c
    +++ b/drivers/usb/serial/keyspan.c
    @@ -838,7 +838,7 @@ static void usa49_indat_callback(struct

    port = (struct usb_serial_port *) urb->context;
    tty = port->tty;
    - if (urb->actual_length) {
    + if (tty && urb->actual_length) {
    /* 0x80 bit is error flag */
    if ((data[0] & 0x80) == 0) {
    /* no error on any byte */
    --


    \
     
     \ /
      Last update: 2008-02-07 21:57    [W:0.023 / U:120.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site