lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Change pci_raw_ops to pci_raw_read/write
    Arjan van de Ven wrote:
    > On Thu, 07 Feb 2008 10:54:05 -0500
    > Tony Camuso <tcamuso@redhat.com> wrote:
    >
    >> Matthew,
    >>
    >> Perhaps I missed it, but did you address Yinghai's concerns?
    >>
    >> Yinghai Lu wrote:
    >>> On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@wil.cx> wrote:
    >>>> -int pci_conf1_write(unsigned int seg, unsigned int bus,
    >>>> +static int pci_conf1_write(unsigned int seg, unsigned int bus,
    >>>> unsigned int devfn, int reg, int len,
    >>>> u32 value)
    >>> any reason to change pci_conf1_read/write to static?
    >>>
    >
    > nothing should use these directly. So static is the right answer ;)

    Agreed. Thanks, Arjan.

    Matthew,
    What about the ATA_RAM addition to Kconfig? Was it accidental,
    or intended? If intended, how is it related?


    \
     
     \ /
      Last update: 2008-02-07 17:39    [W:0.021 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site