lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH][Regression] x86, 32-bit: trim memory not covered by wb mtrrs - FIX
    Date
    On Thursday 07 February 2008 02:20:35 pm Yinghai Lu wrote:
    <snip>
    > > Cool! Yes, Yinghai Lu's patch indeed is the same as mine and its really
    > > surprising that we've used the same variable name too! :)
    >
    > minor difference
    > + trim_start = highest_pfn << PAGE_SHIFT;
    > + trim_size = end_pfn << PAGE_SHIFT;
    >
    > could cause some problem with 32 bit kernel when mem > 4g.
    > becase highest_pfn and end_pfn is unsigned long aka 32 bit ...could
    > overflow.
    >
    > so need to assign thtem to trim_start/trim_end at first
    > or
    > + trim_start = (u64)highest_pfn << PAGE_SHIFT;
    > + trim_size = (u64)end_pfn << PAGE_SHIFT;
    >

    Yea right.. Thanks for pointing that out.

    --
    regards,
    balaji rao


    \
     
     \ /
      Last update: 2008-02-07 12:43    [W:0.043 / U:59.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site