Messages in this thread Patch in this message | | | Date | Wed, 6 Feb 2008 15:51:01 -0800 | From | Greg KH <> | Subject | [patch 05/73] ACPI: video_device_list corruption |
| |
2.6.23-stable review patch. If anyone has any objections, please let us know. ------------------ From: William Lee Irwin III <wli@holomorphy.com>
The ->cap fields of struct acpi_video_device and struct acpi_video_bus are 1B each, not 4B. The oversized memset()'s corrupted the subsequent list_head fields. This resulted in silent corruption without CONFIG_DEBUG_LIST and BUG's with it. This patch uses sizeof() to pass the proper bounds to the memset() calls and thereby correct the bugs.
upstream commit 98934def70b48dac74fac3738b78ab2d1a28edda
Signed-off-by: William Irwin <wli@holomorphy.com> Acked-by: Mikael Pettersson <mikpe@it.uu.se> Signed-off-by: Len Brown <len.brown@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/acpi/video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -573,7 +573,7 @@ static void acpi_video_device_find_cap(s struct acpi_video_device_brightness *br = NULL; - memset(&device->cap, 0, 4); + memset(&device->cap, 0, sizeof(device->cap)); if (ACPI_SUCCESS(acpi_get_handle(device->dev->handle, "_ADR", &h_dummy1))) { device->cap._ADR = 1; @@ -693,7 +693,7 @@ static void acpi_video_bus_find_cap(stru { acpi_handle h_dummy1; - memset(&video->cap, 0, 4); + memset(&video->cap, 0, sizeof(video->cap)); if (ACPI_SUCCESS(acpi_get_handle(video->device->handle, "_DOS", &h_dummy1))) { video->cap._DOS = 1; } --
| |