lkml.org 
[lkml]   [2008]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] power_supply: Remove capacity_level from list of sysfs attributes
    On Wed, 6 Feb 2008 08:50:18 -0200
    Thadeu Lima de Souza Cascardo <cascardo@minaslivre.org> wrote:

    > On Wed, Feb 06, 2008 at 12:53:12AM -0800, Andrew Morton wrote:
    > > On Tue, 5 Feb 2008 14:13:36 -0200 Thadeu Lima de Souza Cascardo <cascardo@minaslivre.org> wrote:
    > >
    > > > ---
    > > > drivers/power/power_supply_sysfs.c | 1 -
    > > > 1 files changed, 0 insertions(+), 1 deletions(-)
    > > >
    > > > diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
    > > > index d482484..13399d1 100644
    > > > --- a/drivers/power/power_supply_sysfs.c
    > > > +++ b/drivers/power/power_supply_sysfs.c
    > > > @@ -106,7 +106,6 @@ static struct device_attribute power_supply_attrs[] = {
    > > > POWER_SUPPLY_ATTR(energy_now),
    > > > POWER_SUPPLY_ATTR(energy_avg),
    > > > POWER_SUPPLY_ATTR(capacity),
    > > > - POWER_SUPPLY_ATTR(capacity_level),
    > > > POWER_SUPPLY_ATTR(temp),
    > > > POWER_SUPPLY_ATTR(temp_ambient),
    > > > POWER_SUPPLY_ATTR(time_to_empty_now),
    > >
    > > What is the reason for making this change?
    >
    > Sorry. The following commit is the reason for this patch.
    >
    > It removes CAPACITY_LEVEL from every other code, leaving the array with
    > sysfs attributes with one more entry than the number of enums in
    > power_supply.h. This leads to some attributes containing the value of
    > the attribute right after it. For example, temp_ambient would have the
    > value of time_to_empty_now. In my case, I had time_to_full_avg have the
    > value which should be in model_name, when the former was usually empty.
    >

    OK, thanks, I think I have enough material there to put together the final
    patch.

    Next time, please do cc the author of the change which you're fixing. And
    please do reply-to-all when working with kernel people, thanks.

    I tagged this fix as needed-in-2.6.24.x as well.


    \
     
     \ /
      Last update: 2008-02-06 22:59    [W:0.022 / U:180.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site