Messages in this thread | | | Date | Tue, 5 Feb 2008 22:32:42 -0800 | From | Andrew Morton <> | Subject | Re: [git pull] Input updates for 2.6.25-rc0 |
| |
Looks OK. Minorish things from a quick scan:
tosakbd_scankeyboard() looks like it'll spend a perfectly wicked amount of time under spin_lock_irqsave().
This code, in tosakbd_probe():
+fail2: + while (--i >= 0) + gpio_free(TOSA_GPIO_KEY_STROBE(i)); + + i = TOSA_KEY_SENSE_NUM; +fail: + while (--i >= 0) { + free_irq(gpio_to_irq(TOSA_GPIO_KEY_SENSE(i)), pdev); + gpio_free(TOSA_GPIO_KEY_SENSE(i)); + }
looks like it'll free irqs and gpios which were never allocated (if i < TOSA_KEY_SENSE_NUM on entry).
+static int __devinit tosakbd_probe(struct platform_device *pdev) {
please integrate checkpatch into your merging process.
i8042_platform_init():
+#if defined(__i386__) || defined(__x86_64__)
use #ifdef CONFIG_X86?
| |