lkml.org 
[lkml]   [2008]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory
On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 01/30/2008 11:36 AM, Bryan Wu wrote:
> > +
> > + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1);
> > + if (ret) {
> > + unregister_chrdev_region(bfin_otp_dev_node, 1);
> > + printk(KERN_ERR PFX "unable to register char device\n");
> > + return ret;
> > + }
> > +
> > + bfin_otp_class = class_create(THIS_MODULE, "otp");
> > + device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
>
> Anyway, wouldn't be easier/better to use misc.c functionality here
> (misc_register() et al.)?

thanks, ive converted this now ... Bryan can post an updated patch :)
http://blackfin.uclinux.org/gf/project/linux-kernel/scmsvn/?action=browse&path=/trunk/drivers/char/bfin-otp.c&r1=4224&r2=4223
-mike


\
 
 \ /
  Last update: 2008-02-05 20:03    [W:0.091 / U:0.052 seconds]
©2003-2014 Jasper Spaans. Advertise on this site