lkml.org 
[lkml]   [2008]   [Feb]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateMon, 4 Feb 2008 13:01:32 +0100
FromIngo Molnar <>
SubjectRe: 2.6.24-git4+ regression
* Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:

> but in such a case, kernel 2.6.24-git13 does oops at startup in 
> sched_slice.

could you tell me more about this oops? You booted unmodified, latest 
-git and it oopsed in sched_slice()? The patch below should work around 
any oopses in sched_slice(). [but this is really a 'must not happen' 
scenario - so a just-for-testing patch]

	Ingo

Index: linux-x86.q/kernel/sched_fair.c
===================================================================
--- linux-x86.q.orig/kernel/sched_fair.c
+++ linux-x86.q/kernel/sched_fair.c
@@ -268,7 +268,8 @@ static u64 sched_slice(struct cfs_rq *cf
 	u64 slice = __sched_period(cfs_rq->nr_running);
 
 	slice *= se->load.weight;
-	do_div(slice, cfs_rq->load.weight);
+	if (cfs_rq->load.weight)
+		do_div(slice, cfs_rq->load.weight);
 
 	return slice;
 }

\
 
 \ /
  Last update: 2008-02-04 13:03    [from the cache]
©2003-2008