lkml.org 
[lkml]   [2008]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t
Date
On Monday 04 February 2008, Borislav Petkov wrote:
> There should be no functional changes resulting from this patch.
>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> ---
> drivers/ide/ide-tape.c | 49 +++++++++++++++++------------------------------
> 1 files changed, 18 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index 442d71c..c8c57ab 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c

[...]

> if (!tape->pc->error) {
> - result = (idetape_read_position_result_t *) tape->pc->buffer;
> - debug_log(DBG_SENSE, "BOP - %s\n", result->bop ? "Yes" : "No");
> - debug_log(DBG_SENSE, "EOP - %s\n", result->eop ? "Yes" : "No");
> + debug_log(DBG_SENSE, "BOP - %s\n",
> + !!(readpos[0] & 0x80) ? "Yes" : "No");
> + debug_log(DBG_SENSE, "EOP - %s\n",
> + !!(readpos[0] & 0x40) ? "Yes" : "No");
> +
> + if (!!(readpos[0] & 0x4)) {
> + printk(KERN_INFO "ide-tape: Block location is unknown"
> + "to the tape\n");

I removed needless "!!" while merging the patch.


\
 
 \ /
  Last update: 2008-02-05 02:19    [W:0.277 / U:1.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site