lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL
Ingo Molnar wrote:
> * Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> +#ifdef CONFIG_SYSCTL
>> static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu);
>> +#endif
>
> instead of adding another #ifdef, a much cleaner solution would be to
> just reorder do_nmi_callback() with unknown_nmi_panic_callback(), and
> eliminate the prototype altogether.
>
> Ingo
>

I was wondering if a smaller patch will be better. But no doult cleaner
code is better. :)


\
 
 \ /
  Last update: 2008-02-03 08:35    [W:0.064 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site