lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mxser: fix compile warning building without CONFIG_PCI
On 02/03/2008 03:59 AM, Li Zefan wrote:
> When build without CONFIG_PIC, got the following warnings:
>
> drivers/char/mxser.c: In function 'mxser_init':
> drivers/char/mxser.c:698: warning: unused variable 'devnum'
> drivers/char/mxser.c:698: warning: unused variable 'busnum'
> drivers/char/mxser.c:697: warning: unused variable 'index'
> drivers/char/mxser.c:696: warning: unused variable 'pdev'
> drivers/char/mxser.c:695: warning: unused variable 'n'
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> drivers/char/mxser.c | 14 ++++++--------
> 1 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index fd0abef..b2cc93d 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -692,10 +692,7 @@ static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxs
>
> static int mxser_init(void)
> {
> - int i, m, retval, b, n;
> - struct pci_dev *pdev = NULL;
> - int index;
> - unsigned char busnum, devnum;
> + int i, m, retval, b;
> struct mxser_hwconf hwconf;
>
> mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
> @@ -834,10 +831,11 @@ static int mxser_init(void)
>
> /* start finding PCI board here */
> #ifdef CONFIG_PCI
> - n = ARRAY_SIZE(mxser_pcibrds) - 1;
> - index = 0;
> b = 0;
> - while (b < n) {
> + while (b < ARRAY_SIZE(mxser_pcibrds)-1) {
> + unsigned char busnum, devnum;
> + struct pci_dev *pdev;
> +
> pdev = pci_get_device(mxser_pcibrds[b].vendor,
> mxser_pcibrds[b].device, pdev);
> if (pdev == NULL) {

This version of driver is no longer in -mm.


\
 
 \ /
  Last update: 2008-02-03 07:19    [W:0.037 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site