Messages in this thread | | | Subject | Re: [PATCH] lockdep: Include all lock classes in all_lock_classes | From | Peter Zijlstra <> | Date | Sun, 03 Feb 2008 20:57:01 +0100 |
| |
On Sun, 2008-02-03 at 12:47 -0700, Dale Farnsworth wrote: > On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote: > > On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote: > > > Add each lock class to the all_lock_classes list when it is > > > first registered. > > > > > > Previously, lock classes were added to all_lock_classes when > > > the lock class was first used. > > > > > Since one of the uses of the list is to find unused locks, this didn't > > > work well. > > > > You mean in lockdep_proc.c to generate the statistics? > > Yes, that's where I noticed it. On my platform, there was one > unused lock which was missed.
OK, I'll clarify the description and take the patch. Thanks!
| |