lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lockdep: Include all lock classes in all_lock_classes
From
Date

On Sun, 2008-02-03 at 12:47 -0700, Dale Farnsworth wrote:
> On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote:
> > On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote:
> > > Add each lock class to the all_lock_classes list when it is
> > > first registered.
> > >
> > > Previously, lock classes were added to all_lock_classes when
> > > the lock class was first used.
> >
> > > Since one of the uses of the list is to find unused locks, this didn't
> > > work well.
> >
> > You mean in lockdep_proc.c to generate the statistics?
>
> Yes, that's where I noticed it. On my platform, there was one
> unused lock which was missed.

OK, I'll clarify the description and take the patch. Thanks!



\
 
 \ /
  Last update: 2008-02-03 20:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site