lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lockdep: Include all lock classes in all_lock_classes
On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote:
> On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote:
> > Add each lock class to the all_lock_classes list when it is
> > first registered.
> >
> > Previously, lock classes were added to all_lock_classes when
> > the lock class was first used.
>
> > Since one of the uses of the list is to find unused locks, this didn't
> > work well.
>
> You mean in lockdep_proc.c to generate the statistics?

Yes, that's where I noticed it. On my platform, there was one
unused lock which was missed.
>
> Another potential issue might be count_matching_names() generating a
> wrong class version.

I haven't looked into that issue yet.

-Dale


\
 
 \ /
  Last update: 2008-02-03 20:51    [W:0.057 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site