lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()
Bartlomiej Zolnierkiewicz wrote:

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/ide-tape.c
> ===================================================================
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
>
> /* Check that we can support this device */
>
> - if (gcw.protocol !=2 )
> - printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
> + if (gcw.protocol != 2)
> + printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
> + gcw.protocol);
> else if (gcw.device_type != 1)
> - printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
> + printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
> + "to tape\n", gcw.device_type);
> else if (!gcw.removable)
> printk(KERN_ERR "ide-tape: The removable flag is not set\n");
> else if (gcw.packet_size != 0) {
> - printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
> - if (gcw.packet_size == 1)
> - printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
> + printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
> + "bytes long\n", gcw.packet_size);

Shouldn't it be either "packet size is not 12 byted" or "packet is not 12
bytes long"?

MBR, Sergei


\
 
 \ /
  Last update: 2008-02-03 18:19    [W:0.398 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site