lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE
[Haavard Skinnemoen - Sun, Feb 03, 2008 at 02:25:06PM +0100]
| [removed bogus @atmel.co address from Cc]
|
| On Sun, 03 Feb 2008 14:22:18 +0300
| Cyrill Gorcunov <gorcunov@gmail.com> wrote:
|
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
|
| Applied, thanks.
|
| I found myself having to grep through include/linux to figure out what
| this _AC macro was really all about, so I added this to the description:
|
| PAGE_SIZE is used both from assembly and C code. We want to have type
| specifiers when using it from C, but this will make the assembler
| confused, so we need to make it conditional.
|
| This is exactly what the _AC macro is for, so using it allows us to
| get rid of a few lines of cpp noise.
|
| My first thought was "Autoconf", and it sent shivers down my spine ;-)
|
| Haavard
|

Thanks, Haavard. (btw, really good joke about Autoconf ;-)

- Cyrill -


\
 
 \ /
  Last update: 2008-02-03 15:07    [W:0.036 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site