[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()
    Roland Dreier wrote:
    > >;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034
    > Actually, looking closer at the kvm changes here, I think that
    > create_vcpu_fd() needs the same treatment as kvm_dev_ioctl_create_vm()
    > gets in the patch because of the race I mentioned in the changelog
    > for my patch: otherwise kvm_vcpu_release() could drop the last
    > reference to vcpu->kvm->filp before the get_file() gets an extra
    > reference.
    > I'm beginning to think that moving the fd_install() out of
    > anon_inode_getfd() really is worth it to make a safer interface.

    It makes is less usable, though (since the last step needs to be taken
    by the caller.

    We might add a int (*prepare_file)(...) parameter which
    anon_inode_getfd() uses to munge the file before installing it.

    error compiling committee.c: too many arguments to function

     \ /
      Last update: 2008-02-28 08:55    [W:0.020 / U:22.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site