lkml.org 
[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 01/21] move isolate_lru_page() to vmscan.c

    > If I understand you right, this is what the incremental patch looks like:
    >
    > Index: linux-2.6.25-rc2-mm1/mm/migrate.c
    > ===================================================================
    > --- linux-2.6.25-rc2-mm1.orig/mm/migrate.c 2008-02-28 21:32:20.000000000 -0500
    > +++ linux-2.6.25-rc2-mm1/mm/migrate.c 2008-02-28 21:32:14.000000000 -0500
    > @@ -841,16 +841,10 @@ static int do_move_pages(struct mm_struc
    > goto put_and_set;
    >
    > err = isolate_lru_page(page);
    > - if (err) {
    > -put_and_set:
    > - /*
    > - * Either remove the duplicate refcount from
    > - * isolate_lru_page() or drop the page ref if it was
    > - * not isolated.
    > - */
    > - put_page(page);
    > - } else
    > + if (!err)
    > list_add_tail(&page->lru, &pagelist);
    > +put_and_set:
    > + put_page(page);
    > set_status:
    > pp->status = err;
    > }
    >
    > Is this OK for me to commit to my tree?
    > (folding it into patch 01/21)

    Yes. thanks.





    \
     
     \ /
      Last update: 2008-02-29 03:51    [W:0.040 / U:154.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site