lkml.org 
[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/12] Fix quota.h includes
    Date
    quota.h currently relies on asm/semaphore.h (through some chain; it
    doesn't actually include semaphore.h itself) to include wait.h. As
    well as being bad practice to rely on an implicit include, subsequent
    patches will break this. While I'm in this file, add atomic.h and
    list.h, and sort the list of includes.

    Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
    ---
    include/linux/quota.h | 8 ++++++--
    1 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/include/linux/quota.h b/include/linux/quota.h
    index 6e0393a..eb560d0 100644
    --- a/include/linux/quota.h
    +++ b/include/linux/quota.h
    @@ -160,14 +160,18 @@ enum {


    #ifdef __KERNEL__
    -#include <linux/spinlock.h>
    -#include <linux/rwsem.h>
    +#include <linux/list.h>
    #include <linux/mutex.h>
    +#include <linux/rwsem.h>
    +#include <linux/spinlock.h>
    +#include <linux/wait.h>

    #include <linux/dqblk_xfs.h>
    #include <linux/dqblk_v1.h>
    #include <linux/dqblk_v2.h>

    +#include <asm/atomic.h>
    +
    extern spinlock_t dq_data_lock;

    /* Maximal numbers of writes for quota operation (insert/delete/update)
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-02-28 07:51    [W:2.432 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site