Messages in this thread | | | Date | Wed, 27 Feb 2008 19:58:39 -0500 | From | Andres Salomon <> | Subject | Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument |
| |
On Wed, 27 Feb 2008 16:31:05 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sat, 23 Feb 2008 01:10:45 -0500 > Andres Salomon <dilinger@queued.net> wrote: > > > @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options) > > if (!*opt) > > continue; > > > > - mode_option = opt; > > + if (!strncmp(opt, "fbsize:", 7)) > > + fbsize = simple_strtoul(opt+7, NULL, 0); > > + else > > + mode_option = opt; > > } > > The above shouldn't be necessary.
It looks like that's done in other drivers in case MODULE isn't defined. I'm assuming this is historical at this point, and manual options parsing can be removed from all fb drivers at this point, or is there another reason why manual parsing would be necessary?
> > And it should have been documented in Documentation/kernel-parameters.txt.
Yeah, I wasn't actually sure about that; I did check for other fb drivers documenting stuff in kernel-parameters.txt, and didn't see it. It looks like they instead document stuff in Documentation/fb/. Which is preferred?
> > And "fbsize=N" would be a lot more conventional than "fbsize:N" >
I can certainly change that. Regarding convention, I toyed with renaming it 'vram' (as most of the fb drivers use that), and will probably do that unless Jordan objects.
> I suspect that the formulation you have here will not permit "fbsize:128k", > whereas "fbsize=128k" or "gxfb.fbsize=128k" should work. Needs checking. > > > return 0; > > @@ -456,5 +458,8 @@ module_exit(gxfb_cleanup); > > module_param(mode_option, charp, 0); > > MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])"); > > > > +module_param(fbsize, int, 0); > > +MODULE_PARM_DESC(fbsize, "video memory size"); > > + > > Because the module_param() already makes fbsize available on the kernel > boot command line via gxfb.fbsize=42 (or something similar). > >
| |