lkml.org 
[lkml]   [2008]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] page reclaim throttle take2
On Wed, 27 Feb 2008, KOSAKI Motohiro wrote:

> > Adding yet another sysctl for this functionality seems unnecessary, unless
> > it is attempting to address other VM problems where page reclaim needs to
> > be throttled when it is being stressed. Those issues need to be addressed
> > directly, in my opinion, instead of attempting to workaround it by
> > limiting the number of concurrent reclaim threads.
>
> hm,
>
> could you post another patch?
> I hope avoid implementless discussion.
> and I hope compare by benchmark result.
>

My suggestion is merely to make the number of concurrent page reclaim
threads be a function of how many online cpus there are. Threads can
easily be added or removed for cpu hotplug events by callback functions.

That's different than allowing users to change the number of threads with
yet another sysctl. Unless there are situations that can be presented
where tuning the number of threads is advantageous to reduce lock
contention, for example, and not simply working around other VM problems,
then I see no point for an additional sysctl.

So my suggestion is to implement this in terms of
CONFIG_NUM_RECLAIM_THREADS_PER_CPU and add callback functions for cpu
hotplug events that add or remove this number of threads.

David


\
 
 \ /
  Last update: 2008-02-27 08:23    [W:0.140 / U:0.224 seconds]
©2003-2014 Jasper Spaans. Advertise on this site