lkml.org 
[lkml]   [2008]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 27 Feb 2008 19:29:15 +0100
FromMark Pearson <>
SubjectRe: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
Karol Kozimor wrote:
> On 26-02-2008, at 21:42, Julia Lawall wrote:
>> if (invert) /* invert target value */
>> - led_out = !led_out & 0x1;
>> + led_out = !(led_out & 0x1);
>>
>> if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
>> printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
>
>
> IIRC we're just supposed to flip the last bit here, so the original code
> is correct.
> Best regards,
>

Seems an odd way of doing:

led_out ^= 0x01;

It this due to some optimisation?

Cheers, Mark.


\
 
 \ /
  Last update: 2008-02-27 19:31    [from the cache]
©2003-2010