Messages in this thread Patch in this message | | | Subject | RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24 | Date | Wed, 27 Feb 2008 14:11:55 +0100 | From | "Wappler Marcel" <> |
| |
-----Original Message----- >> #include <linux/types.h> >> @@ -103,6 +107,7 @@ >> - '3' from resolv.h */ >> >> #define NONE __constant_htonl(INADDR_NONE) >> +#define ZERO __constant_htonl(((unsigned long int) 0x00000000)) >This should probably use INADDR_ANY. My first try went in this direction. But at a second look I thought that the names ANY (255.255.255.255) and NONE (0.0.0.0) are indirect leading to confusion. The interpretation of the zero addresses in the DHCPDISCOVER packet is in the kind of 'no address' and not of 'any addressee'. So the meaning and usage of INADDR_ANY and ZERO may be totally different in this file. In my opinion it is necessary to distinguish between INADDR_ANY and the ZERO address which ist requested to be in the DHCPDISCOVER packet.
Marcel -- Marcel Wappler Bridgeco AG CH-8600 Dübendorf Switzerland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |