lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 26 Feb 2008 09:55:41 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] x86: add the debugfs interface for the sysprof tool
* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> Hi,
> 
> On Tue, Feb 26, 2008 at 8:27 AM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> > >  You could try passing the --callgraph option to opcontrol.
> >
> >  Hmm, perhaps I am missing something but I don't think that does what
> >  sysprof does. At least I can't find where in the oprofile kernel code
> >  does it save the full stack trace for user-space. John?
> 
> Ok, so as pointed out by Nicholas/Andrew, oprofile does indeed do 
> exactly what sysprof does (see 
> arch/x86/oprofile/backtrace.c::backtrace_address, for example). So, 
> Soeren, any other reason we can't use the oprofile kernel module for 
> sysprof?

as i pointed it out earlier in the thread, the oprofile implementation 
seems buggy because when an event comes from NMI context 
__copy_from_user_inatomic() can fault and re-enable NMIs - causing 
possible stack recursion/corruption. Does not look like an easy fix.

	Ingo


\
 
 \ /
  Last update: 2008-02-26 09:59    [from the cache]
©2003-2008