[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] ide-cd: fix some codestyle and most of the issues

    On Tuesday 26 February 2008, Borislav Petkov wrote:
    > Signed-off-by: Borislav Petkov <>
    > ---
    > drivers/ide/ide-cd.c | 634 +++++++++++++++++++++++++------------------------
    > 1 files changed, 323 insertions(+), 311 deletions(-)

    With 300 lines changed this is not trivial to review/apply anymore
    (yeah, I sound like a broken record ;-) and since I've already applied
    Paolo's patch from two days ago this one heavily rejects...

    Moreover md5sum is different before/after the patch - I tried really hard
    to figure out why (by reverting some changes) but finally I gave up.

    - resync
    - factor out changes which affect resulting binary
    - resubmit


     \ /
      Last update: 2008-02-26 23:31    [W:0.029 / U:4.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site