![]() | ||||||||||
Messages in this thread |
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote: > also fix error in early_init_intel and reference about x86_capality, > because it is array already.., prevent possible data corruption... hm, why should there be data corruption: > - set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); > + set_cpu_cap(c, X86_FEATURE_CONSTANT_TSC); cpu_cpu_cap() is currently defined as: #define set_cpu_cap(c, bit) set_bit(bit, (unsigned long *)((c)->x86_capability) which is the same. set_cpu_cap() is indeed the cleaner form to do this so your patch is correct as a cleanup. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-02-26 07:23 [W:0.489 / U:0.050 seconds] ©2003-2008 Jasper Spaans | ||||||||||