lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: 2.6.25-rc1/2 CD/DVD burning broken
    From
    On Mon, Feb 25, 2008 at 11:08:55PM +0100, Andreas Schwab wrote:
    > Borislav Petkov <petkovbb@googlemail.com> writes:
    >
    > > On Mon, Feb 25, 2008 at 08:38:22PM +0100, Andreas Schwab wrote:
    > >> "Kiyoshi Ueda" <k-ueda@ct.jp.nec.com> writes:
    > >>
    > >> > I'm looking at this problem, but currently no idea why the conversion
    > >> > to blk_end_request causes it.
    > >>
    > >> cdrom_newpc_intr apparently never sets rq->sense_len.
    > >>
    > >
    > > actually it does, see the code chunk around line 1188 in 2.6.25-rc2, for
    > > example.
    >
    > Yes, it does, but it always adds zero.

    yep, true. Does that fix your dvd burning problem?

    > Move counting of sense bytes into the transfer loop.
    >
    > Signed-off-by: Andreas Schwab <schwab@suse.de>
    >
    > ---
    > drivers/ide/ide-cd.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > --- linux-2.6.25-rc3.orig/drivers/ide/ide-cd.c 2008-02-25 01:03:31.000000000 +0100
    > +++ linux-2.6.25-rc3/drivers/ide/ide-cd.c 2008-02-25 22:54:42.000000000 +0100
    > @@ -1182,11 +1182,10 @@ static ide_startstop_t cdrom_newpc_intr(
    > else
    > rq->data += blen;
    > }
    > + if (!write && blk_sense_request(rq))
    > + rq->sense_len += blen;
    > }
    >
    > - if (write && blk_sense_request(rq))
    > - rq->sense_len += thislen;
    > -
    > /*
    > * pad, if necessary
    > */
    >
    > Andreas.
    >
    > --
    > Andreas Schwab, SuSE Labs, schwab@suse.de
    > SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
    > PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
    > "And now for something completely different."

    --
    Regards/Gruß,
    Boris.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-02-26 05:27    [W:2.126 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site