lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mmiotrace full patch, preview 1
On Sun, 24 Feb 2008 19:03:23 +0200 Pekka Paalanen <pq@iki.fi> wrote:

> arch/x86/Kconfig.debug | 33 +++
> arch/x86/mm/Makefile | 5 +
> arch/x86/mm/fault.c | 13 +
> arch/x86/mm/kmmio.c | 541 +++++++++++++++++++++++++++++++++++++++++++
> arch/x86/mm/mmio-mod.c | 541 +++++++++++++++++++++++++++++++++++++++++++
> arch/x86/mm/pageattr.c | 1 +
> arch/x86/mm/pf_in.c | 489 ++++++++++++++++++++++++++++++++++++++
> arch/x86/mm/pf_in.h | 39 +++
> arch/x86/mm/testmmiotrace.c | 76 ++++++
> include/linux/mmiotrace.h | 104 +++++++++

Please feed the diff through scritps/checkpatch.pl and consider addressing
the things which it finds.

> +static DECLARE_MUTEX(kmmio_init_mutex);

That's not a mutex.

> + down(&kmmio_init_mutex);

It's a semaphore. Please do convert it to a mutex.

Andy, I'd say that addition of new semaphores is worth a warning - they're
rarely legitimate.



\
 
 \ /
  Last update: 2008-02-25 23:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site