Messages in this thread | | | Date | Mon, 25 Feb 2008 22:57:49 +0100 | From | Jan Kara <> | Subject | Re: [patch 06/38] quota: turn quotas off when remounting read-only |
| |
On Fri 22-02-08 16:29:51, Greg KH wrote: > 2.6.24-stable review patch. If anyone has any objections, please let us > know. Hmm, this patch is certainly safe from a kernel POV but changes a behavior WRT userspace. Previously, user could do: quotaon / mount -o remount,ro / <be lucky> mount -o remount,rw / <have quotas still turned on>
But with the patch, the quotas will be turned off. So I'm not sure whether it's acceptable as a -stable thing...
Honza > > ------------------ > > > From: Jan Kara <jack@suse.cz> > > patch 66191dc622f5ff0a541524c4e96fdacfacfda206 in mainline. > > Turn off quotas before filesystem is remounted read only. Otherwise quota > will try to write to read-only filesystem which does no good... We could > also just refuse to remount ro when quota is enabled but turning quota off > is consistent with what we do on umount. > > Signed-off-by: Jan Kara <jack@suse.cz> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > --- > fs/super.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/fs/super.c > +++ b/fs/super.c > @@ -603,6 +603,7 @@ int do_remount_sb(struct super_block *sb > mark_files_ro(sb); > else if (!fs_may_remount_ro(sb)) > return -EBUSY; > + DQUOT_OFF(sb); > } > > if (sb->s_op->remount_fs) { > > -- -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |