Messages in this thread | | | Date | Mon, 25 Feb 2008 23:07:05 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH] Memory Resource Controller Add Boot Option |
| |
Paul Menage wrote: > On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: >> I thought about it, but it did not work out all that well. The reason being, >> that the memory controller is called in from places besides cgroup. >> mem_cgroup_charge_common() for example is called from several places in mm. >> Calling into cgroups to check, enabled/disabled did not seem right. > > You wouldn't need to call into cgroups - if it's a flag in the subsys > object (which is defined in memcontrol.c) you'd just say > > if (mem_cgroup_subsys.disabled) { > ... > } > > I'll send out a prototype for comment.
Sure thing, if css has the flag, then it would nice. Could you wrap it up to say something like css_disabled(&mem_cgroup_subsys)
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL
| |