lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[(RT RFC) PATCH v2 9/9] remove the extra call to try_to_take_lock
    Date
    From: Peter W. Morreale <pmorreale@novell.com>

    Remove the redundant attempt to get the lock. While it is true that the
    exit path with this patch adds an un-necessary xchg (in the event the
    lock is granted without further traversal in the loop) experimentation
    shows that we almost never encounter this situation.

    Signed-off-by: Peter W. Morreale <pmorreale@novell.com>
    ---

    kernel/rtmutex.c | 6 ------
    1 files changed, 0 insertions(+), 6 deletions(-)

    diff --git a/kernel/rtmutex.c b/kernel/rtmutex.c
    index b81bbef..266ae31 100644
    --- a/kernel/rtmutex.c
    +++ b/kernel/rtmutex.c
    @@ -756,12 +756,6 @@ rt_spin_lock_slowlock(struct rt_mutex *lock)
    spin_lock_irqsave(&lock->wait_lock, flags);
    init_lists(lock);

    - /* Try to acquire the lock again: */
    - if (try_to_take_rt_mutex(lock)) {
    - spin_unlock_irqrestore(&lock->wait_lock, flags);
    - return;
    - }
    -
    BUG_ON(rt_mutex_owner(lock) == current);

    /*


    \
     
     \ /
      Last update: 2008-02-25 17:35    [W:0.032 / U:93.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site