lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [SCSI] gdth: misc cleanups, preparation for ISA/EISA hotplug API
Christoph Hellwig wrote:
> On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
>> hmmmmm. We'll see how it plays out... on the remove side, the above is
>> exact what happens in gdth_remove_one() without my patch, thus
>> consolidating two cases of the same code into one. There is a less-strong
>> argument for doing the allocation that way, but it may turn out to be
>> useful anyway once the ISA/EISA API conversion is complete.
>
> EISA ->remove has a different prototype from PCI ->remove from ISA
> ->remove, so gdth_remove_one will be split up eventually. Having the
> scsi_host_put duplicated in each shouldn't be too much of a problem :)

We'll see what the final result is... you might turn out to be right.
If people want to avoid merging this patch because of this issue, that's
fine.

Jeff





\
 
 \ /
  Last update: 2008-02-24 06:37    [W:0.253 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site