Messages in this thread |  | | | Date | Sun, 24 Feb 2008 10:23:49 +0000 | | From | Mark Brown <> | | Subject | Re: [PATCH 4/6] regulator: regulator core. | |
On Sat, Feb 23, 2008 at 09:52:17AM +0000, Russell King - ARM Linux wrote:
> On Sat, Feb 23, 2008 at 12:05:38AM -0800, Andrew Morton wrote:
> > > +#undef current
> > err, no ;) Please rename your stuff.
> Renaming is not an option - "current" is an electronic term for which
> there is no alternative. The real problem is this __ATTR macro crap:
Indeed, and this is already being worked around by
drivers/power/power_supply_sysfs.c:
#define POWER_SUPPLY_ATTR(_name) \
{ \
.attr = { .name = #_name, .mode = 0444, .owner = THIS_MODULE }, \
.show = power_supply_show_property, \
.store = NULL, \
}
|  |