lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 00/16] (Resend) Use get_personality()
From
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 00/16] (Resend) Use get_personality()
Date: Sat, 23 Feb 2008 11:16:29 -0800
Message-ID: <20080223111629.4d8d2c7b.akpm@linux-foundation.org>

> On Sat, 23 Feb 2008 13:37:31 -0500 Christoph Hellwig <hch@infradead.org> wrote:
>
> > On Sat, Feb 23, 2008 at 12:27:10PM +0300, Alexey Dobriyan wrote:
> > > > Use get_personality() can hide the task_struct internals a bit.
> > >
> > > ->personality is going to become something less trivial?
> > > Sorry, but you sound like C++ people writing tons of pointless get/set
> > > wrappers. And your get_personality() is worse -- C++ would write it as
> > >
> > > current->personality()
> > >
> > > and again, even here, it's immediately visible that current task is
> > > involved, not some other task.
> >
> > Yes, completely agreement. While I might have introduced this gem
> > back then it is entirely stupid if you think about it. Please send
> > patches to kill get_personality and just use current->personality
> > instead.
> >
>
> yup.
>
> We'll generally only add wrappers of this form if we need to provide
> alternative implementations, or if we expect that we shall do so in the
> future.
>

Ok. I will send a patch to remove it.


\
 
 \ /
  Last update: 2008-02-24 05:11    [W:0.061 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site