Messages in this thread | | | Date | Sun, 24 Feb 2008 08:17:52 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller |
| |
Andrew Morton wrote: > On Sat, 23 Feb 2008 06:33:34 -0800 "Paul Menage" <menage@google.com> wrote: > >> On Thu, Feb 21, 2008 at 8:29 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: >>> Looks good, except for the name uint(), can we make it u64(). Integers are 32 >>> bit on both ILP32 and LP64, but we really read/write 64 bit values. >> Yes, that's true. But read_uint() is more consistent with all the >> other instances in cgroups and subsystems. So if we were to call it >> res_counter_read_u64() I'd also want to rename all the other >> *read_uint functions/fields to *read_u64 too. Can I do that in a >> separate patch? >> > > Sounds sensible to me. >
Sure, fair enough.
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL
| |