Messages in this thread |  | | | Date | Sat, 23 Feb 2008 00:03:23 -0800 | | From | Andrew Morton <> | | Subject | Re: [PATCH] macb: Fix speed setting |
On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>> > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by
> conversion to generic PHY layer in kernel 2.6.23.
So.. shouldn't we fix it in 2.6.23.x and 2.6.24.x?
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> drivers/net/macb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 81bf005..1d210ed 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device *dev)
>
> if (phydev->duplex)
> reg |= MACB_BIT(FD);
> - if (phydev->speed)
> + if (phydev->speed == SPEED_100)
> reg |= MACB_BIT(SPD);
>
> macb_writel(bp, NCFGR, reg);
|  |