lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/16] (Resend) Use get_personality()
On Sat, Feb 23, 2008 at 12:27:10PM +0300, Alexey Dobriyan wrote:
> > Use get_personality() can hide the task_struct internals a bit.
>
> ->personality is going to become something less trivial?
> Sorry, but you sound like C++ people writing tons of pointless get/set
> wrappers. And your get_personality() is worse -- C++ would write it as
>
> current->personality()
>
> and again, even here, it's immediately visible that current task is
> involved, not some other task.

Yes, completely agreement. While I might have introduced this gem
back then it is entirely stupid if you think about it. Please send
patches to kill get_personality and just use current->personality
instead.

Thanks.


\
 
 \ /
  Last update: 2008-02-23 19:39    [from the cache]
©2003-2011 Jasper Spaans