[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] x86: add the debugfs interface for the sysprof tool
    On Sat, Feb 23, 2008 at 10:11 AM, Andrew Morton
    <> wrote:
    > Seems a poor idea to me. Sure, oprofile is "hard to set up", but not if
    > your distributor already did it for you.
    > Sidebar: the code uses the utterly crappy register_timer_hook() which
    > a) is woefully misnamed and
    > b) is racy and
    > c) will disrupt oprofile if it is being used. And vice versa.

    I wonder if sysprof should hook to the same interrupt as oprofile then?

    On Sat, Feb 23, 2008 at 10:11 AM, Andrew Morton
    <> wrote:
    > This code adds a new kernel->userspace interface which is not even
    > documented in code comments. It appears to use a pollable debugfs file in
    > /proc somewhere, carrying an unspecified payload.


    > This reads a single item even if there were 100 queued, which is quite
    > inefficient.
    > We already have infrastructure for bulk kernel->user transfer in
    > kernel/relay.c?

    Agreed. This seems like a perfect fit with relayfs.

     \ /
      Last update: 2008-02-23 15:57    [W:0.023 / U:8.200 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site