lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Accessor macros vs reference counting
Matthew Wilcox wrote:
> On Sat, Feb 23, 2008 at 04:14:08PM +0800, WANG Cong wrote:
>
>> Use get_personality() macro instead of explicit reference
>> for parisc code.
>> - if (personality(current->personality) == PER_LINUX32
>> + if (personality(get_personality()) == PER_LINUX32
>>
>
> Hm. We have an interesting clash of conventions here.
>
> On the one hand, we have the java-style accessor convention.
> get_personality()/set_personality().
>

Is get_personality() thought to be better than current->personality? To
me, the latter seems more meaningful, and I'd rather see it than the former.


\
 
 \ /
  Last update: 2008-02-23 13:49    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site