Messages in this thread | | | Date | Sat, 23 Feb 2008 11:01:40 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c |
| |
* Joe Perches <joe@perches.com> wrote:
> > printk(KERN_ERR "%d multicall(s) failed: cpu %d\n", > > ret, smp_processor_id()); > > - for(i = 0; i < b->mcidx; i++) { > > + for (i = 0; i < b->mcidx; i++) { > > printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n", > > The printk needs a KERN_ERR prefix
yes - but we prefer to isolate the "does not change the .o in any way" cleanups from cleanups that materially change kernel behavior. (such as printing something else)
Ingo
| |