Messages in this thread | | | Subject | Re: Merging of completely unreviewed drivers | From | Krzysztof Halasa <> | Date | Fri, 22 Feb 2008 23:28:58 +0100 |
| |
Al Viro <viro@ZenIV.linux.org.uk> writes:
> IMO the line length overruns make good warnings. Not as in "here's a cheap > way to get more changesets", but as in "that code might have other problems > nearby" kind of heuristics.
Sure, it does. However the human looking at the code is far better at spotting such problems. Machine-generated warnings are great when the machine is actually better than human.
Anyway, warnings are one thing and line limit is another. We may raise the limit leaving the 80-chars warning in place. Unless there are too many false positives, of course. -- Krzysztof Halasa
| |