Messages in this thread |  | | | Date | Thu, 21 Feb 2008 09:39:07 +0100 | | From | Nadia Derbey <> | | Subject | Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem | |
Matt Helsley wrote:
> On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote:
> > <snip>> >>+#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */
>>+> > > It's not quite the maximum anymore, is it? More like the minumum
> maximum ;). A better name might better document what the test is
> actually trying to do.> > One question I have is whether the unpatched test is still valuable.
> Based on my limited knowledge of the test I suspect it's still a correct
> test of message queues. If so, perhaps renaming the old test (so it's
> not confused with a performance regression) and adding your patched
> version is best?>
Yes, you're completely right.
I'll resend a patch today.
Regards,
Nadia
|  |